-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: from1DNMRVariables #53
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You forgot to expose the new method in index.ts
export * from './from1DNMRVariables';
And this lead to a type script error, please have a look.
If you could also update a little bit the README and JsDoc it would be nice. It is completely outdated.
@@ -4,7 +4,8 @@ import { MeasurementXYVariables } from 'cheminfo-types'; | |||
import { convert } from 'jcampconverter'; | |||
import { xMultiply } from 'ml-spectra-processing'; | |||
|
|||
import { fromVariables, JcampOptions } from '..'; | |||
import { JcampOptions } from '..'; | |||
import from1DNMRVariables from '../from1DNMRVariables'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because in this file we only test from1DNMRVariables, please rename the file to from1DNMRVariables.test.ts
close: #52