feat: show/hide kind column in ranges panels

close #1562
cheminfo · May 20, 2022 · 6c3899b · 6c3899b
1 parent 5da8f24
commit 6c3899b
Show file tree

Hide file tree

Showing 6 changed files with 22 additions and 9 deletions.
diff --git a/src/component/panels/RangesPanel/RangesPreferences.tsx b/src/component/panels/RangesPanel/RangesPreferences.tsx
@@ -77,6 +77,12 @@ const formatFields: NucleusPreferenceField[] = [
     checkControllerName: 'coupling.show',
     formatControllerName: 'coupling.format',
   },
+  {
+    id: 8,
+    label: 'Kind :',
+    checkControllerName: 'showKind',
+    hideFormatField: true,
+  },
 ];
 
 function RangesPreferences(props, ref) {

diff --git a/src/component/panels/RangesPanel/RangesTable.tsx b/src/component/panels/RangesPanel/RangesTable.tsx
@@ -115,7 +115,7 @@ function RangesTable({
               <FaLink style={{ fontSize: 10 }} />
             </th>
             <th>Σ</th>
-            <th>Kind</th>
+            {preferences.showKind && <th>Kind</th>}
             <th>{''}</th>
           </tr>
         </thead>

diff --git a/src/component/panels/RangesPanel/RangesTableRow.tsx b/src/component/panels/RangesPanel/RangesTableRow.tsx
@@ -265,6 +265,7 @@ function RangesTableRow({
         onHoverSignal={onHoverSignal}
         onHoverRange={onHoverRange}
         rowSpanTags={rowSpanTags}
+        showKind={preferences.showKind}
       />
     </tr>
   );

diff --git a/src/component/panels/RangesPanel/TableColumns/ActionsColumn.tsx b/src/component/panels/RangesPanel/TableColumns/ActionsColumn.tsx
@@ -44,26 +44,30 @@ interface ActionsColumnProps {
     onMouseEnter: () => void;
     onMouseLeave: () => void;
   };
+  showKind: boolean;
 }
 
 function ActionsColumn({
   rowData,
   onHoverSignal,
   rowSpanTags,
+  showKind,
 }: ActionsColumnProps) {
   const { editRange, deleteRange, changeRangeSignalKind, zoomRange } =
     useEditRangeModal(rowData);
 
   return (
     <Fragment>
-      <td {...onHoverSignal}>
-        <Select
-          onChange={changeRangeSignalKind}
-          data={SignalKinds}
-          defaultValue={rowData.tableMetaInfo.signal.kind}
-          style={selectBoxStyle}
-        />
-      </td>
+      {showKind && (
+        <td {...onHoverSignal}>
+          <Select
+            onChange={changeRangeSignalKind}
+            data={SignalKinds}
+            defaultValue={rowData.tableMetaInfo.signal.kind}
+            style={selectBoxStyle}
+          />
+        </td>
+      )}
       <td {...rowSpanTags} css={styles}>
         <button type="button" className="delete-button" onClick={deleteRange}>
           <FaRegTrashAlt />

diff --git a/src/component/reducer/preferences/panelsPreferencesDefaultValues.ts b/src/component/reducer/preferences/panelsPreferencesDefaultValues.ts
@@ -36,6 +36,7 @@ const getRangeDefaultValues = (
     deltaHz: { show: false, format: '0.00' },
     coupling: { show: true, format: '0.00' },
     jGraphTolerance: nucleus === '1H' ? 0.2 : nucleus === '13C' ? 2 : 0, //J Graph tolerance for: 1H: 0.2Hz 13C: 2Hz
+    showKind: true,
   };
 
   return getPreferences(preferences, nucleus);

diff --git a/src/component/workspaces/Workspace.ts b/src/component/workspaces/Workspace.ts
@@ -42,6 +42,7 @@ interface RangesNucleusPreferences {
   deltaHz: ColumnPreferences;
   coupling: ColumnPreferences;
   jGraphTolerance: number;
+  showKind: boolean;
 }
 
 interface PeaksNucleusPreferences {