fix: zero filling size list

cheminfo · Nov 27, 2023 · d44f519 · d44f519
1 parent f691630
commit d44f519
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 8 deletions.
diff --git a/src/component/elements/Select.tsx b/src/component/elements/Select.tsx
@@ -95,20 +95,36 @@ const Select = forwardRef(function Select(
       )}
 
       {items.map((option) => {
-        if (
-          typeof option[itemValueField] !== 'string' ||
-          typeof option[itemTextField] !== 'string'
-        ) {
-          // TODO: throw error
+        const value = option[itemValueField];
+
+        if (!['number', 'string'].includes(typeof option[itemTextField])) {
+          // eslint-disable-next-line no-console
+          console.log(
+            `The '${itemTextField}' field should be a string , option : ${JSON.stringify(
+              option,
+            )}`,
+          );
+          return null;
+        }
+        if (!['number', 'string'].includes(typeof value)) {
+          // eslint-disable-next-line no-console
+          console.log(
+            `The '${itemValueField}' field should be either a string or a number, option : ${JSON.stringify(
+              option,
+            )}`,
+          );
           return null;
         }
+
+        const label = String(option[itemTextField]);
+
         return (
           <option
             key={JSON.stringify(option)}
-            value={option[itemValueField]}
+            value={value}
             data-value={JSON.stringify(option)}
           >
-            {textRender?.(option[itemTextField]) || option[itemTextField]}
+            {textRender?.(label) || label}
           </option>
         );
       })}

diff --git a/src/data/utilities/generateNumbersPowerOfX.ts b/src/data/utilities/generateNumbersPowerOfX.ts
@@ -21,6 +21,6 @@ function formatNumber(number: number): string | number {
   } else if (number >= 1024) {
     return `${number / 1024}K`;
   } else {
-    return number;
+    return `${number}`;
   }
 }