fix: avoid unmounts in spectra panel (#2197)

Closes: #1901
cheminfo · Feb 23, 2023 · fc2f07a · fc2f07a
1 parent 5c0556d
commit fc2f07a
Showing 1 changed file with 15 additions and 12 deletions.
diff --git a/src/component/panels/SpectrumsPanel/SpectrumsTabs.tsx b/src/component/panels/SpectrumsPanel/SpectrumsTabs.tsx
@@ -1,6 +1,6 @@
 /** @jsxImportSource @emotion/react */
 import { css } from '@emotion/react';
-import { useState, useMemo, memo } from 'react';
+import { useState, useMemo, memo, useCallback } from 'react';
 
 import { Datum1D } from '../../../data/types/data1d';
 import { Datum2D } from '../../../data/types/data2d';
@@ -49,25 +49,28 @@ function SpectrumsTabsInner({
     dispatch({ type: SET_ACTIVE_TAB, tab: tab.tabid });
   }
 
-  function openSettingHandler(event, selectedSpectrum) {
+  const openSettingHandler = useCallback((event, selectedSpectrum) => {
     event.stopPropagation();
     setSettingModalPosition({
       x: event.nativeEvent.clientX,
       y: event.nativeEvent.clientY,
     });
     setSelectedSpectrum(selectedSpectrum);
     setIsSettingModalDisplayed(true);
-  }
+  }, []);
 
-  function handleChangeVisibility(d, key) {
-    dispatch({
-      type: CHANGE_VISIBILITY,
-      payload: {
-        id: d.id,
-        key,
-      },
-    });
-  }
+  const handleChangeVisibility = useCallback(
+    (d, key) => {
+      dispatch({
+        type: CHANGE_VISIBILITY,
+        payload: {
+          id: d.id,
+          key,
+        },
+      });
+    },
+    [dispatch],
+  );
 
   function handleChangeActiveSpectrum(e, spectrum) {
     setTimeout(() => {