Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phase correction and baseline correction do not force integration recalculation #2637

Closed
lpatiny opened this issue Aug 18, 2023 · 2 comments · Fixed by #2646 or #2625
Closed

Phase correction and baseline correction do not force integration recalculation #2637

lpatiny opened this issue Aug 18, 2023 · 2 comments · Fixed by #2646 or #2625
Assignees
@hamed-musallam
Labels
bug Something isn't working

Comments

@lpatiny
Copy link
Member

lpatiny commented Aug 18, 2023

When changing the spectrum (add / remove filter) the relative integration and absolute integration should be recalculate.

This is true for ranges and integrals (also for 2D).
@lpatiny lpatiny added the bug Something isn't working label Aug 18, 2023
@hamed-musallam
Copy link
Member

this issue is fixed in nmr-processing https://github.com/cheminfo/nmr-processing/pull/318 and waiting for the PR to be merege and have a new release of mmr-processing

@hamed-musallam
Copy link
Member

hamed-musallam added a commit that referenced this issue Aug 24, 2023
@hamed-musallam
fix: recalculate integration when toggling or deleting filter
57919e4 
close #2637
@hamed-musallam hamed-musallam mentioned this issue Aug 24, 2023
Merged
@hamed-musallam hamed-musallam linked a pull request Aug 24, 2023 that will close this issue
fix: recalculate integration when toggling or deleting filter #2646
Merged
hamed-musallam added a commit that referenced this issue Aug 24, 2023
@hamed-musallam
fix: recalculate integration when toggling or deleting filter
81d4388 
close #2637
@cheminfo-bot cheminfo-bot mentioned this issue Aug 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hamed-musallam hamed-musallam

Labels
bug Something isn't working
Projects
NMR and Cheminfo projects organisation
Archived in project
Milestone
No milestone
2 participants
@lpatiny @hamed-musallam