Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Blueprint-related warnings #2808

Merged
merged 1 commit into from
Dec 15, 2023
Merged

fix: Blueprint-related warnings #2808

merged 1 commit into from
Dec 15, 2023

Conversation

targos
Copy link
Member

@targos targos commented Dec 15, 2023

  • Disable React StrictMode.
  • Do not pass isOpen to div.

Refs: zakodium-oss/react-science#610

- Disable React StrictMode.
- Do not pass `isOpen` to div.

Refs: zakodium-oss/react-science#610
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 091fea3
Status: ✅  Deploy successful!
Preview URL: https://977d313d.nmrium.pages.dev
Branch Preview URL: https://fix-blueprint.nmrium.pages.dev

View logs

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 40 lines in your changes are missing coverage. Please review.

Comparison is base (21fde70) 2.06% compared to head (091fea3) 2.06%.

Files Patch % Lines
src/component/toolbar/BasicToolBar.tsx 0.00% 21 Missing ⚠️
src/demo/layouts/Admin.tsx 0.00% 19 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2808   +/-   ##
=====================================
  Coverage   2.06%   2.06%           
=====================================
  Files        638     638           
  Lines      62388   62386    -2     
  Branches     682     682           
=====================================
  Hits        1290    1290           
+ Misses     60510   60508    -2     
  Partials     588     588           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@targos targos merged commit 6618ec1 into main Dec 15, 2023
12 of 13 checks passed
@targos targos deleted the fix-blueprint branch December 15, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant