Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactions with metadata #116

Merged
merged 17 commits into from
Apr 15, 2023
Merged

Interactions with metadata #116

merged 17 commits into from
Apr 15, 2023

Conversation

cbouy
Copy link
Member

@cbouy cbouy commented Apr 15, 2023

Fixes #56, #71

Modifies the interaction classes and the rest of the codebase to access/return metadata about interactions

@codecov
Copy link

codecov bot commented Apr 15, 2023

Codecov Report

Merging #116 (275014a) into master (9edd387) will increase coverage by 0.22%.
The diff coverage is 96.73%.

@@            Coverage Diff             @@
##           master     #116      +/-   ##
==========================================
+ Coverage   95.74%   95.96%   +0.22%     
==========================================
  Files          10       11       +1     
  Lines        1080     1066      -14     
==========================================
- Hits         1034     1023      -11     
+ Misses         46       43       -3     
Impacted Files Coverage Δ
prolif/parallel.py 53.19% <0.00%> (+3.19%) ⬆️
prolif/fingerprint.py 95.03% <95.00%> (-1.06%) ⬇️
prolif/ifp.py 100.00% <100.00%> (ø)
prolif/interactions.py 99.18% <100.00%> (-0.01%) ⬇️
prolif/plotting/network.py 96.20% <100.00%> (+0.56%) ⬆️
prolif/utils.py 99.09% <100.00%> (-0.12%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


with pytest.raises(TypeError, match="Can't instantiate abstract class _Dummy"):
_Dummy()
class _Dummy(Interaction):

Check notice

Code scanning / CodeQL

Unused local variable

Variable _Dummy is not used.

def test_wrong_key(ifp):
with pytest.raises(KeyError, match="does not correspond to a valid IFP key"):
ifp[0]

Check notice

Code scanning / CodeQL

Statement has no effect

This statement has no effect.
@cbouy cbouy linked an issue Apr 15, 2023 that may be closed by this pull request
@cbouy cbouy merged commit 433a400 into master Apr 15, 2023
@cbouy cbouy deleted the metadata branch April 15, 2023 21:07
@cbouy cbouy added this to the v2.0.0 milestone Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant