Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: MulticomponentMPNN and MPNN can't be loaded from checkpoint file in Python 3.12 #738

Closed
JacksonBurns opened this issue Mar 21, 2024 · 2 comments · Fixed by #714 or #741
Closed

[BUG]: MulticomponentMPNN and MPNN can't be loaded from checkpoint file in Python 3.12 #738

JacksonBurns opened this issue Mar 21, 2024 · 2 comments · Fixed by #714 or #741
Labels
bug Something isn't working
Milestone
v2.0.0

Comments

@JacksonBurns
Copy link
Member

This issues is tracking a bug which was discovered in PR #714 - the MulticomponentMPNN class cannot be loaded from a checkpoint because lightning incorrectly infers the class arguments. This can only be fixed by the upstream, so the following steps have been taken here:

This seems like some problem with lightning that we have no control over, so it may be best to just wrap the load_from_checkpoint method in MulticomponentMPNN and raise an error/warning about how Python 3.12 is bugged for that function and then wait for lightning to figure it out.

Originally posted by @JacksonBurns in #714 (comment)
@JacksonBurns JacksonBurns mentioned this issue Mar 21, 2024
Merged
@JacksonBurns JacksonBurns changed the title [BUG]: MulticomponentMPNN can't be loaded from checkpoint file in Python 3.12 [BUG]: MulticomponentMPNN and MPNN can't be loaded from checkpoint file in Python 3.12 Mar 22, 2024
@JacksonBurns
Copy link
Member Author

Turns out that this actually impacts both the MPNN and the MulticomponentMPNN.

@JacksonBurns
Copy link
Member Author

TODO: just try instantiating and then pickling a (Multicomponent)MPNN, use dill's detect module if unsucessful to diagnose why

@JacksonBurns JacksonBurns added the bug Something isn't working label Mar 22, 2024
JacksonBurns added a commit to JacksonBurns/chemprop that referenced this issue Mar 22, 2024
@JacksonBurns
load submodules in separate function instead of load_from_checkpoint
283437f 
fix suggested by @knathan to possibly renable loading from checkpoint on 3.12  could resolve chemprop#738
JacksonBurns added a commit to JacksonBurns/chemprop that referenced this issue Mar 22, 2024
@JacksonBurns
load submodules in separate function instead of load_from_checkpoint
9789d29 
fix suggested by @knathan to possibly renable loading from checkpoint on 3.12  could resolve chemprop#738
JacksonBurns added a commit to JacksonBurns/chemprop that referenced this issue Mar 22, 2024
@JacksonBurns
load submodules in separate function instead of load_from_checkpoint
d0e34dc 
fix suggested by @knathan to possibly renable loading from checkpoint on 3.12  could resolve chemprop#738
@JacksonBurns JacksonBurns linked a pull request Mar 22, 2024 that will close this issue
[v2]: CI Overhaul (and make v2 actually _pass_ the CI) #714
Merged
JacksonBurns added a commit to JacksonBurns/chemprop that referenced this issue Mar 22, 2024
@JacksonBurns
load submodules in separate function instead of load_from_checkpoint
bd710be 
fix suggested by @knathan to possibly renable loading from checkpoint on 3.12  could resolve chemprop#738
@KnathanM KnathanM mentioned this issue Mar 23, 2024
Merged
@JacksonBurns JacksonBurns linked a pull request Mar 23, 2024 that will close this issue
Fix load from checkpoint in python 3.12 #741
Merged
@kevingreenman kevingreenman added this to the v2.0.0 milestone Mar 28, 2024
@KnathanM KnathanM closed this as completed Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v2.0.0
3 participants
@JacksonBurns @kevingreenman @KnathanM