Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix for multi-molecules in scaffold split #159

Merged
merged 1 commit into from
Apr 16, 2021
Merged

Conversation

hesther
Copy link
Contributor

@hesther hesther commented Apr 2, 2021

Another bug fix for multi-molecule input. This is analogous to the changes that were made in 2c98bf7 (checking if multi-molecule input is used, raise an exception, else flatten the list of molecules).

@hesther hesther linked an issue Apr 2, 2021 that may be closed by this pull request
@kevingreenman
Copy link
Member

Should a similar change be made in chemprop/data/scaffold.py around line 71?

@hesther
Copy link
Contributor Author

hesther commented Apr 2, 2021

This change was already made to chemprop/data/scaffold.py in commit 2c98bf7. On (current) line 70+71, we check whether the number of molecules is larger than 1, and in line 79 we flatten the list of lists in chemprop/data/scaffold.py. So yes, it absolutely also affects chemprop/data/scaffold.py, but it was already fixed, and somehow scripts/create_crossval_splits.py was forgotten at that time.

Copy link
Contributor

@mliu49 mliu49 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@hesther hesther merged commit 3f30478 into master Apr 16, 2021
@hesther hesther deleted the bugfix_scaffold_split branch April 16, 2021 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with scaffold_to_smiles function
3 participants