bugfix for training within git repo #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have also reported this to Kyle: TAP Issue 57 |
cjmcgill
approved these changes
Aug 3, 2021
|
Should I just merge it then? |
|
I wasn’t sure if it made more sense for me to go ahead and merge it or if I needed to let the decision making initiative go back to you one more time. I’m not sure what the best practice is for the situation where it’s the two of us reviewing each other. But I guess maybe if no further delay is necessary then it makes no sense to create an extra step. I think I was overthinking this. |
|
Great! Yeah, I wasn't sure whether we wanted to merge PR 190 and 193 first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, tap causes an issue when training a model within a git repo that has no origin specified. To reproduce the error:
mkdir test; cd test; git initpython <path_to_chemprop>/train.py --data_path <path_to_data_csv> --dataset_type regressionThis is a tap issue since when writing arguments to file, it runs
git remote get-url origin, in the current folder, not in the chemprop folder (which would be correct). I will open a tap issue too, but to stay compatible with older versions of tap (and until they fix it), I think it would be good to have a workaround.