V2/update-branch-name #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shihchengli
approved these changes
Apr 18, 2024
shihchengli
force-pushed
the
v2/update-branch-name
branch
from
7f34f06
to
2f6c1dd
Compare
KnathanM
approved these changes
Apr 19, 2024
|
The tests for this PR won't run because it removes v2/dev from the branches that have PR's tested. A solution would be to first copy our finished v2/dev branch to "main" and then switch this PR to merge into "main". |
|
@KnathanM good point, though I think we can bypass that testing requirement for this PR since it will be the last one merged for v2.0 and doesn't make changes that could break any tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove references to
v2/devfrom the code, since this branch will be renamed tomainbefore the release. This PR should be merged after all the other v2.0 PRs since it will remove thev2/devbranch from the CI.