v2.0 readme updates #824
Merged
v2.0 readme updates #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shihchengli
reviewed
Apr 22, 2024
KnathanM
reviewed
Apr 22, 2024
CONTRIBUTING.md
Outdated
There was a problem hiding this comment.
Suggested change:
When you're ready to be considered for merging, check the "Ready to go" -> When you're ready to be considered for merging, click the "Ready for review"
Remove * [Thinkful PR example](http://www.thinkful.com/learn/github-pull-request-tutorial/#Time-to-Submit-Your-First-PR) as the link is broken
There was a problem hiding this comment.
good catches, done
|
|
||
| **License:** Chemprop is free to use under the [MIT License](LICENSE.txt). The Chemprop logo is free to use under [CC0 1.0](docs/source/_static/images/logo/LICENSE.txt). | ||
|
|
||
| **References**: Please cite the appropriate papers if Chemprop is helpful to your research. |
There was a problem hiding this comment.
Should we note that all these references were for v1? My main concern is the interpretation functionality line, given we don't have that in v2 yet.
There was a problem hiding this comment.
good point, I've clarified this
KnathanM
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update README and other non-code files for the release of v2.0