-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker images for v2 #841
Docker images for v2 #841
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JacksonBurns thanks for the PR! I just have a couple questions before we merge
now part of `ci.yml`
ugh. the latest macos runners (the apple silicon ones) dont support the default DDP strategy in lightning and are not accessible from our runners which causes errors when lightning attempts to use it when @kevingreenman I guess we should resolve the test failures in a separate PR before this one. |
did this just change today? I thought all the tests were passing earlier today |
Yeah this only just changed, the CI is failing now too: https://github.com/chemprop/chemprop/actions/runs/8845256777 |
It was probably torch 2.3, which just came out: https://pytorch.org/blog/pytorch2-3/ |
finally found someone else reporting the error: https://discuss.pytorch.org/t/mps-back-end-out-of-memory-on-github-action/189773/2 pytorch knows about it and has closed the issue tracking it: pytorch/pytorch#111449 (comment) and yet this issue remains open showing that this is not resolved: actions/runner-images#9254 solution is to not run on the latest macos... sad |
see: chemprop#841 (comment) thank god apple made their own gpu, what even are standards anyway
@kevingreenman switching back to macos13 which uses intel chips works. If you are ok with this we can merge as-is to get CI passing and re-open #776 to track adding apple silicon runners back |
@JacksonBurns that sounds good to me. It looks like the status checks are still showing the |
yes, the branch protection still expects macos latest. With your approval here, I have now changed this rule to instead look for |
thanks! |
This PR:
I have already built and pushed a v2.0.0 image manually to Dockerhub. In the future we will have builds continuously made - when we want to do a release we just pull the built image, tag it, and push it back.