Fix small bugs in hpopt #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduced the search space for the init and final lr ratios and max_lr Fixed the warmup epochs to be an integer (and not None) Fixed the batch size to be integer (powers of 2) Replace quniform to qrandint to ensure int for agrregation_norm, depth, ffn_hidden_dim, ffn_num_layers, message_hidden_dim.
JacksonBurns
requested changes
May 21, 2024
shihchengli
reviewed
May 22, 2024
This was referenced May 23, 2024
|
I have addressed all the comments. Please re-review and merge! |
…ch space accordingly
|
Made some more fixes re: warmup epochs. Open for re-review. |
shihchengli
reviewed
May 24, 2024
|
All comments addressed. Open for re-review and merge |
|
@akshatzalte one last small thing, then it's good to go. |
JacksonBurns
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hyperparameter optimization was giving very small (~10^-10) Learning rates, which seemed wrong to people in the devs meeting (5/20/2024). This was because the search space was too vast.
Also, the batch-size was not enforced to be an integer currently.
Reduction of search space and fixing the values in hpopt.
Example / Current workflow
In the current workflow, quniform outputs a float value which is not correct.
For the batch-size, tune.choice() used to simplify it and enforce only 16, 32.., 256 is selected.
Bugfix / Desired workflow
Reduced the search space for the init and final lr ratios and max_lr Fixed the warmup epochs to be an integer (and not None) Fixed the batch size to be an integer (powers of 2)
Replace quniform to qrandint to ensure int for agrregation_norm, depth, ffn_hidden_dim, ffn_num_layers, message_hidden_dim.
Questions
none
Relevant issues
#851
Checklist