【Hackathon 6th Fundable Projects 2 No.22】cppcoreguidelines-pro-type-m…

…ember-init_1-part (PaddlePaddle#63938) * restore * minor changes * format * minor changes
chen2016013 · May 26, 2024 · dae3249 · dae3249
1 parent 5f9534a
commit dae3249
Show file tree

Hide file tree

Showing 14 changed files with 60 additions and 25 deletions.
diff --git a/paddle/fluid/distributed/ps/service/communicator/communicator.cc b/paddle/fluid/distributed/ps/service/communicator/communicator.cc
@@ -33,12 +33,18 @@ using phi::SelectedRows;
 const uint32_t MAX_FEASIGN_NUM = 1024 * 100 * 100;
 
 inline double GetCurrentUS() {
-  struct timeval time;
-  gettimeofday(&time, nullptr);
+  struct timeval time = {0, 0};
+  gettimeofday(&time, NULL);
   return 1e+6 * time.tv_sec + time.tv_usec;
 }
 
-Communicator::Communicator() = default;
+Communicator::Communicator()
+    : envs(),
+      trainers_(0),
+      send_varname_to_ctx_(),
+      recv_varname_to_ctx_(),
+      recv_scope_(nullptr),
+      xpu_temp_scope_(nullptr) {}
 
 void Communicator::InitGFlag(const std::string &gflags) {
   VLOG(3) << "Init With Gflags:" << gflags;

diff --git a/paddle/fluid/distributed/test/ctr_accessor_test.cc b/paddle/fluid/distributed/test/ctr_accessor_test.cc
@@ -181,6 +181,16 @@ TEST(downpour_feature_value_accessor_test, test_update) {
     std::vector<float> embed_g2sum;
     std::vector<float> embedx_w;
     std::vector<float> embedx_g2sum;
+    DownpourSparseValueTest()
+        : slot(0),
+          unseen_days(0),
+          delta_score(0),
+          show(0),
+          click(0),
+          embed_w(0),
+          embed_g2sum(),
+          embedx_w(),
+          embedx_g2sum() {}
 
     void to_array(float* ptr, size_t dim) {
       ptr[0] = slot;
@@ -210,6 +220,8 @@ TEST(downpour_feature_value_accessor_test, test_update) {
     float click;
     float embed_g;
     std::vector<float> embedx_g;
+    DownpourSparsePushValueTest()
+        : slot(0), show(0), click(0), embed_g(0), embedx_g() {}
   };
   std::vector<float*> exp_value;
   for (auto i = 0u; i < item_size; ++i) {

diff --git a/paddle/fluid/framework/io/shell.cc b/paddle/fluid/framework/io/shell.cc
@@ -59,6 +59,7 @@ static int close_open_fds_internal() {
     off_t d_off;
     unsigned short d_reclen = 0;  // NOLINT
     char d_name[256];             // NOLINT
+    linux_dirent() : d_off(0), d_name{} {}
   };
 
   int dir_fd = open("/proc/self/fd", O_RDONLY);
@@ -151,7 +152,7 @@ static int shell_popen_fork_internal(const char* real_cmd,
 }
 
 static int read_from_pipe(FILE* fp, std::string* output) {
-  std::array<char, 4096> buf;
+  std::array<char, 4096> buf = {};
   while (true) {
     int n = static_cast<int>(fread(buf.data(), 1, 4096, fp));
     if (n <= 0) {
@@ -187,7 +188,7 @@ std::shared_ptr<FILE> shell_popen(const std::string& cmd,
 
   std::string real_cmd = "set -o pipefail; " + cmd;
 
-  std::array<int, 2> pipe_fds;
+  std::array<int, 2> pipe_fds = {};
   if (pipe(pipe_fds.data()) != 0) {
     *err_no = -1;
     return nullptr;
@@ -300,8 +301,8 @@ std::pair<std::shared_ptr<FILE>, std::shared_ptr<FILE>> shell_p2open(
 
   std::string real_cmd = "set -o pipefail; " + cmd;
 
-  std::array<int, 2> pipein_fds;
-  std::array<int, 2> pipeout_fds;
+  std::array<int, 2> pipein_fds = {};
+  std::array<int, 2> pipeout_fds = {};
   if (pipe(pipein_fds.data()) != 0) {
     return {nullptr, nullptr};
   }

diff --git a/paddle/fluid/framework/new_executor/instruction/control_flow/pylayer_instruction.cc b/paddle/fluid/framework/new_executor/instruction/control_flow/pylayer_instruction.cc
@@ -49,7 +49,7 @@ PyLayerInstruction::PyLayerInstruction(
     pir::Operation* op,
     ValueExecutionInfo* value_exec_info,
     interpreter::ExecutionConfig execution_config)
-    : InstructionBase(id, place) {
+    : InstructionBase(id, place), output_vars_(), fwd_skip_gc_names_() {
   PADDLE_ENFORCE(op->isa<paddle::dialect::PyLayerOp>(),
                  phi::errors::PreconditionNotMet(
                      "Cond instruction only support pylayer op"));

diff --git a/paddle/fluid/framework/new_executor/instruction/control_flow/while_instruction.cc b/paddle/fluid/framework/new_executor/instruction/control_flow/while_instruction.cc
@@ -51,7 +51,11 @@ WhileInstruction::WhileInstruction(
     pir::Operation* op,
     ValueExecutionInfo* parent_exe_info,
     interpreter::ExecutionConfig execution_config)
-    : InstructionBase(id, place) {
+    : InstructionBase(id, place),
+      inputs_(),
+      outputs_(),
+      body_inter_(nullptr),
+      external_input_names_() {
   PADDLE_ENFORCE(op->isa<paddle::dialect::WhileOp>(),
                  phi::errors::PreconditionNotMet(
                      "While instruction only support While op"));

diff --git a/paddle/fluid/framework/new_executor/standalone_executor.cc b/paddle/fluid/framework/new_executor/standalone_executor.cc
@@ -37,7 +37,14 @@ namespace framework {
 StandaloneExecutor::StandaloneExecutor(const platform::Place& place,
                                        const interpreter::Plan& plan,
                                        Scope* scope)
-    : place_(place), plan_(plan), scope_(scope) {
+    : place_(place),
+      plan_(plan),
+      interpretercores_(),
+      scope_(scope),
+      micro_batch_scopes_(),
+      fetch_var_names_(),
+      fetch_list_(),
+      vec_force_events_to_wait_() {
   int64_t micro_batch_num = plan_.MicroBatchNum();
   vec_force_events_to_wait_.resize(micro_batch_num);
   for (int64_t i = 0; i < micro_batch_num; ++i) {

diff --git a/paddle/fluid/platform/profiler.cc b/paddle/fluid/platform/profiler.cc
@@ -584,6 +584,7 @@ MemEventRecorder::RecordMemEvent::RecordMemEvent(const Place &place,
     : place_(place),
       bytes_(bytes),
       start_ns_(PosixInNsec()),
+      end_ns_(0),
       alloc_in_(phi::CurAnnotationName()) {
   PushMemEvent(start_ns_, end_ns_, bytes_, place_, alloc_in_);
 }

diff --git a/paddle/fluid/pybind/op_function_common.cc b/paddle/fluid/pybind/op_function_common.cc
@@ -56,7 +56,7 @@ class OpAttrTypeMap {
   }
 
  private:
-  OpAttrTypeMap() = default;
+  OpAttrTypeMap() : ops_attrtype_map_() {}
   std::unordered_map<
       std::string,
       std::unordered_map<std::string, paddle::framework::proto::AttrType>>

diff --git a/paddle/phi/core/distributed/nccl_comm_task.cc b/paddle/phi/core/distributed/nccl_comm_task.cc
@@ -48,13 +48,15 @@ NCCLCommTask::NCCLCommTask(const phi::Place& place,
                nccl_comm,
                stream,
                comm_type),
+      timeout_(std::chrono::milliseconds(timeout)),
       sync_op_(sync_op),
-      use_calc_stream_(use_calc_stream) {
+      use_calc_stream_(use_calc_stream),
+      nccl_start_event_(nullptr),
+      nccl_end_event_(nullptr) {
   start_trace_updated_ = false;
   start_event_created_ = false;
   end_event_created_ = false;
   start_time_ = std::chrono::steady_clock::now();
-  timeout_ = std::chrono::milliseconds(timeout);
 }
 
 void NCCLCommTask::StartRecord() {

diff --git a/paddle/phi/kernels/funcs/gpc.cc b/paddle/phi/kernels/funcs/gpc.cc
@@ -956,9 +956,9 @@ void gpc_polygon_clip(gpc_op op,
   polygon_node *cf = nullptr;
   vertex_node *vtx = nullptr;
   vertex_node *nv = nullptr;
-  std::array<h_state, 2> horiz;
-  std::array<int, 2> in;
-  std::array<int, 2> exists;
+  std::array<h_state, 2> horiz = {};
+  std::array<int, 2> in = {};
+  std::array<int, 2> exists = {};
   std::array<int, 2> parity = {LEFT, LEFT};
   int c = 0;
   int v = 0;
@@ -1603,10 +1603,10 @@ void gpc_tristrip_clip(gpc_op op,
   vertex_node *ltn = nullptr;
   vertex_node *rt = nullptr;
   vertex_node *rtn = nullptr;
-  std::array<h_state, 2> horiz;
+  std::array<h_state, 2> horiz = {};
   vertex_type cft = NUL;
-  std::array<int, 2> in;
-  std::array<int, 2> exists;
+  std::array<int, 2> in = {};
+  std::array<int, 2> exists = {};
   std::array<int, 2> parity = {LEFT, LEFT};
   int s = 0;
   int v = 0;

diff --git a/paddle/phi/kernels/funcs/jit/test.cc b/paddle/phi/kernels/funcs/jit/test.cc
@@ -1177,9 +1177,9 @@ TEST(JITKernel_helper, GetAllCandidateFuncs) {
 
 TEST(JITKernel_helper, pack_weights) {
   const int N = 8 * 60, K = 2;
-  std::array<std::array<float, N>, K> src;
-  std::array<std::array<float, N>, K> yref;
-  std::array<float, N * K> y;
+  std::array<std::array<float, N>, K> src = {};
+  std::array<std::array<float, N>, K> yref = {};
+  std::array<float, N* K> y = {};
   float* x = &(src[0][0]);
   float* ref = &(yref[0][0]);
   for (int i = 0; i < N * K; ++i) {

diff --git a/test/cpp/inference/api/analyzer_detect_functional_mkldnn_tester.cc b/test/cpp/inference/api/analyzer_detect_functional_mkldnn_tester.cc
@@ -30,6 +30,7 @@ namespace analysis {
 struct Record {
   std::vector<float> data;
   std::vector<int32_t> shape;
+  Record() : data(), shape() {}
 };
 
 Record ProcessALine(const std::string &line, const std::string &shape_line) {

diff --git a/test/cpp/phi/api/test_from_blob.cc b/test/cpp/phi/api/test_from_blob.cc
@@ -84,7 +84,7 @@ using phi::memory_utils::Copy;
 TEST(GetPlaceFromPtr, GPU) {
   using paddle::GetPlaceFromPtr;
 
-  std::array<float, 6> cpu_data;
+  std::array<float, 6> cpu_data = {};
   auto cpu_data_place = GetPlaceFromPtr(cpu_data.data());
   ASSERT_EQ(cpu_data_place, phi::CPUPlace());
   std::cout << "cpu_data_place: " << cpu_data_place << std::endl;
@@ -137,7 +137,7 @@ TEST(from_blob, GPU) {
 
   // 3.2 check tensor values
   auto* gpu_tensor_data = gpu_tensor.template data<float>();
-  std::array<float, 6> gpu_tensor_data_cpu;
+  std::array<float, 6> gpu_tensor_data_cpu = {};
   Copy(phi::CPUPlace(),
        gpu_tensor_data_cpu.data(),
        gpu0,
@@ -155,7 +155,7 @@ TEST(from_blob, GPU) {
   // 3.4 test other API
   auto gpu_tensor_pow = paddle::experimental::pow(gpu_tensor, 2);
   auto* gpu_tensor_pow_data = gpu_tensor_pow.template data<float>();
-  std::array<float, 6> gpu_tensor_pow_data_cpu;
+  std::array<float, 6> gpu_tensor_pow_data_cpu = {};
   Copy(phi::CPUPlace(),
        gpu_tensor_pow_data_cpu.data(),
        gpu0,

diff --git a/test/deprecated/cpp/inference/api/analyzer_vis_tester.cc b/test/deprecated/cpp/inference/api/analyzer_vis_tester.cc
@@ -26,6 +26,7 @@ namespace analysis {
 struct Record {
   std::vector<float> data;
   std::vector<int32_t> shape;
+  Record() : data(), shape() {}
 };
 
 Record ProcessALine(const std::string &line) {