Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve the code robustness of slist #115

Merged
merged 1 commit into from
Jan 15, 2023

Conversation

wjiec
Copy link
Contributor

@wjiec wjiec commented Jan 15, 2023

  1. use explicit panic instead of runtime errors such as null pointers
  2. add test cases for SList.Front and SList.Back
  3. sListIterator uniformly uses the same type of receiver(Go recommended)

@sonarcloud
Copy link

sonarcloud bot commented Jan 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@coveralls
Copy link

coveralls commented Jan 15, 2023

Pull Request Test Coverage Report for Build 3923059014

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 13 of 13 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 3890411830: 0.0%
Covered Lines: 1782
Relevant Lines: 1782

💛 - Coveralls

@chen3feng chen3feng merged commit 57cfac4 into chen3feng:master Jan 15, 2023
@chen3feng
Copy link
Owner

Many thanks for your contributions.

@wjiec wjiec deleted the enhance/slist branch January 15, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants