Hgf bert #9
Merged
Hgf bert #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'gsoc2020' into hgf_bert
findmyway
approved these changes
Jul 1, 2020
| @@ -0,0 +1,30 @@ | |||
| using JSON | |||
There was a problem hiding this comment.
JSON3 has great support for de/serializing AbstractDict, see: https://quinnj.github.io/JSON3.jl/stable/#StructTypes.DictType-1 . (No need to change here, just a gentle reminder.😃 )
There was a problem hiding this comment.
What's the different between using JSON and JSON3 ?
There was a problem hiding this comment.
Since that AbstractHGFConfig is already a subtype of AbstractDict, I guess with JSON3, https://github.com/chengchingwen/Transformers.jl/pull/9/files/dac873007f6289b7e0f74f6a70ac22f3905c43ff#diff-56f47ab93bc96fbe6afa99bce9821a9aR11-R28 this part can be slightly simplified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.