Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-native compatibility, for reals this time #110

Merged
merged 4 commits into from Jul 30, 2015

Conversation

threepointone
Copy link
Contributor

tests pass, demos work, webpack warning has gone away.

import {Spring, TransitionSpring} from 'react-motion/lib/SpringNative'; should now work on react-native (once published)

@chenglou
Copy link
Owner

=D awesome

The parallel of require('react-motion') here is require('react-motion/lib/SpringNative'). I find that kinda weird. Is there some consistency we can have?

@threepointone
Copy link
Contributor Author

Point. How about react-motion/native?

@chenglou
Copy link
Owner

👍
(Also, build/ still works too right)
Testing correct exports will get better soon. Sorry for the lack of polish right now.

@threepointone
Copy link
Contributor Author

Yes, build/ still works too. Heading to catch a flight, will catch up in a few hours.

@threepointone
Copy link
Contributor Author

(caught up)

@chenglou
Copy link
Owner

You're awesome. Also my water bottle spilled in my bag and ruined the notebook you gave me.

chenglou added a commit that referenced this pull request Jul 30, 2015
react-native compatibility, for reals this time
@chenglou chenglou merged commit d47243d into chenglou:master Jul 30, 2015
@gaearon
Copy link
Contributor

gaearon commented Jul 30, 2015

niiice

chenglou added a commit that referenced this pull request Jul 30, 2015
Check #110. Will leave README alone since people might accidentally refer to
master and wonder why their installed lib doesn't work. We'll move stuff
onto the docs site soon so the "readme on master" thing won't be a
problem anymore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants