-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Motion.@onRest #273
Add Motion.@onRest #273
Conversation
Addresses chenglou#235
5840dd7
to
212bb30
Compare
Thanks a lot! |
My pleasure! |
super! |
wow! awesome! |
See previous and next few commits. We're doing a small rewrite of the `styles` merging algorithm of TM that'll cache `TransitionStyle`/`TransitionPlainStyle` `key` as object keys internally. This means the user provided `key` must be a string since js objects keys cast stuff to that. (Also adding a TODO following #273.)
@appsforartists @chenglou Can this be used for |
@leopoldjoy currently only implemented for Motion, which is why I waited before the imminent public release, because I wanted it on all 3 components. But after discussing with people I've noticed that they only need it for Motion? |
Yes, I agree that it seems like it's only really relevant to |
I'll publish it officially this week or next so don't worry about it. |
@chenglou Ok, sounds good! Thanks for your work! |
onRest for TransitionMotion could be also very useful. |
@chenglou @appsforartists Great work guys! would be awesome to have that in master at least for |
Would be really useful to have this for |
Echo @AlastairTaft except for |
I don't think @chenglou or I use this library anymore, so if you do and you want |
Is there a new flavor of the month for this kind of thing we should look at instead? 😜 |
I still like React Motion. I've got an experimental motion library that I use for my work, but it's not documented or published, which unfortunately makes it hard for other folks to use. |
Heh. How it goes for most of us, seems like. My use-case is a side-panel that squishes a map. Ideally, the map can be told to recenter/repaint after the squishing animation completes, but honestly I'm not sure anyone will notice it isn't happening anytime soon. If it becomes an issue that makes it to the top of my backlog, then you can look for a PR from me. ;) |
See React-Spring or Popmotion (both are in active development). I haven't tried either yet, but they are on my todo list. 😄 |
We still use react motion in many places. Though the only component that we work with is the main Motion, so I have no context/interest in modifying any other components. |
looks like popmotion/pose is a bit higher level, which is nice. |
I don't intend for this to land until after I've used it and made sure we're solving the right problem, but I'm opening this now so @chenglou can play with it (and maybe add Flow if there are places I've missed).
See also #235.