Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Motion.@onRest #273

Merged
merged 1 commit into from
Jan 28, 2016
Merged

Add Motion.@onRest #273

merged 1 commit into from
Jan 28, 2016

Conversation

appsforartists
Copy link
Contributor

I don't intend for this to land until after I've used it and made sure we're solving the right problem, but I'm opening this now so @chenglou can play with it (and maybe add Flow if there are places I've missed).

See also #235.

chenglou added a commit that referenced this pull request Jan 28, 2016
@chenglou chenglou merged commit 3e03e07 into chenglou:development Jan 28, 2016
@chenglou
Copy link
Owner

Thanks a lot!

@appsforartists
Copy link
Contributor Author

My pleasure!

@threepointone
Copy link
Contributor

super!

@kumarharsh
Copy link

wow! awesome!

chenglou added a commit that referenced this pull request Jan 30, 2016
See previous and next few commits.

We're doing a small rewrite of the `styles` merging algorithm of TM
that'll cache `TransitionStyle`/`TransitionPlainStyle` `key` as object
keys internally. This means the user provided `key` must be a string
since js objects keys cast stuff to that.

(Also adding a TODO following #273.)
@leopoldjoy
Copy link

@appsforartists @chenglou Can this be used for <Motion />, <StaggeredMotion />, and <TransitionMotion />?

@chenglou
Copy link
Owner

@leopoldjoy currently only implemented for Motion, which is why I waited before the imminent public release, because I wanted it on all 3 components. But after discussing with people I've noticed that they only need it for Motion?

@leopoldjoy
Copy link

Yes, I agree that it seems like it's only really relevant to Motion. I was going to open a pull request for the README.md documentation as I found it extremely useful, would this be helpful/relevant?

@chenglou
Copy link
Owner

I'll publish it officially this week or next so don't worry about it.

@leopoldjoy
Copy link

@chenglou Ok, sounds good! Thanks for your work!

@sunflowerdeath
Copy link

onRest for TransitionMotion could be also very useful.

@haraldox
Copy link

haraldox commented Apr 8, 2016

@chenglou @appsforartists Great work guys! would be awesome to have that in master at least for <Motion> :)

@AlastairTaft
Copy link

Would be really useful to have this for <StaggeredMotion />. I'm trying to animate page navigation. Each page is made up of a handful of panels, maybe 3 or 4. When the user navigates between pages I want each panel to staggered-ly spring in. I need to know when the animation is done so that I can remove the old page component.

@ollwenjones
Copy link

Echo @AlastairTaft except for TransitionMotion

@appsforartists
Copy link
Contributor Author

I don't think @chenglou or I use this library anymore, so if you do and you want @onRest for the other components, you should open a PR. 😃

@ollwenjones
Copy link

Is there a new flavor of the month for this kind of thing we should look at instead? 😜

@appsforartists
Copy link
Contributor Author

I still like React Motion.

I've got an experimental motion library that I use for my work, but it's not documented or published, which unfortunately makes it hard for other folks to use.

@ollwenjones
Copy link

Heh. How it goes for most of us, seems like. My use-case is a side-panel that squishes a map. Ideally, the map can be told to recenter/repaint after the squishing animation completes, but honestly I'm not sure anyone will notice it isn't happening anytime soon. If it becomes an issue that makes it to the top of my backlog, then you can look for a PR from me. ;)

@kumarharsh
Copy link

See React-Spring or Popmotion (both are in active development). I haven't tried either yet, but they are on my todo list. 😄

@nkbt
Copy link
Collaborator

nkbt commented Aug 10, 2018

We still use react motion in many places. Though the only component that we work with is the main Motion, so I have no context/interest in modifying any other components.
((tbh I would be quite happy to have only that one available and not add up to the bundle))

@ollwenjones
Copy link

looks like popmotion/pose is a bit higher level, which is nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants