Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ES6 class style for creating react components #455

Merged
merged 4 commits into from
Apr 25, 2017

Conversation

Holi0317
Copy link
Contributor

No description provided.

.gitignore Outdated
@@ -14,3 +14,4 @@ lib

/demos/**/all.*
/build/
.idea/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be in your global .gitignore file on your working machine

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for forgetting to keep track of this PR ;P

Copy link
Collaborator

@nkbt nkbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thank heaps.

I though first that we might need to change our peer dependencies

"peerDependencies": {
  "react": ">=0.13.2 || ^0.14 || ^15.0.0"		     
}

But it looks like React.Component was introduced in 0.13.0, so we are still OK.

That means we don't need to release major version with this change.

@nkbt nkbt merged commit b494d24 into chenglou:master Apr 25, 2017
@MichaelDeBoey
Copy link
Contributor

MichaelDeBoey commented Apr 25, 2017

@nkbt The prop-types package is only compatible with React ^0.14.9 or React ^15.3.0

@nkbt
Copy link
Collaborator

nkbt commented Apr 25, 2017

Ouch. Thanks for that @MichaelDeBoey

@MichaelDeBoey
Copy link
Contributor

@nkbt Will be fixed with #458

@nkbt
Copy link
Collaborator

nkbt commented Apr 25, 2017

I will publish 0.5.0 (sort of "major" in 0.x way) then, after #457 is merged (tomorrow, since I left my laptop in the office)

@nkbt
Copy link
Collaborator

nkbt commented Apr 26, 2017

Just published 0.5.0 🤞

Notes
https://github.com/chenglou/react-motion/releases/tag/v0.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants