-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ES6 class style for creating react components #455
Conversation
.gitignore
Outdated
@@ -14,3 +14,4 @@ lib | |||
|
|||
/demos/**/all.* | |||
/build/ | |||
.idea/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be in your global .gitignore
file on your working machine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for forgetting to keep track of this PR ;P
This reverts commit 36260a2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Thank heaps.
I though first that we might need to change our peer dependencies
"peerDependencies": {
"react": ">=0.13.2 || ^0.14 || ^15.0.0"
}
But it looks like React.Component was introduced in 0.13.0, so we are still OK.
That means we don't need to release major version with this change.
@nkbt The |
Ouch. Thanks for that @MichaelDeBoey |
I will publish |
Just published Notes |
No description provided.