Upgrade stack #545
Merged
Upgrade stack #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I wanted to upgrade only babel but everything else was broken so I upgraded babel, webpack, eslint and karma. Disabled a lot of eslint rules to not change existing code. Maybe it's better to migrate to prettier later. This changes will unblock me from providing smaller output.
|
/cc @chenglou |
|
We need to rerun travis |
|
Friendly ping @chenglou |
|
Thanks for the ping. To be clear, is there a user-facing change here? Or just for us devs? |
|
@chenglou This one only for devs. |
|
Bundle is slightly changed with new versions of webpack/babel but I don't think there's anything significant. |
|
@chenglou Tests are passed. |
|
If there's no user-facing impact then sure. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to upgrade only babel but everything else was broken so I
upgraded babel, webpack, eslint and karma.
Disabled a lot of eslint rules to not change existing code. Maybe it's
better to migrate to prettier later.
This changes will unblock me from providing smaller output.