Tweak Path

Remove the `/` sugar for now. Because the idiom differs sometime (some folks prefer // for example). Providing this out of the box would be a bit too opinionated. Folks can easily alias if they want anyway.
chenglou · Jan 23, 2020 · dcf69fb · dcf69fb
1 parent 0f0bd0b
commit dcf69fb
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 27 deletions.
diff --git a/src/Path.bs.js b/src/Path.bs.js
diff --git a/src/Path.re b/src/Path.re
@@ -26,8 +26,6 @@ external join: array(string) => string = "join";
 
 [@bs.module "path"] external join2: (string, string) => string = "join";
 
-let (/) = join2;
-
 [@bs.module "path"] external normalize: string => string = "normalize";
 
 [@bs.module "path"] external parse: string => t = "parse";
@@ -71,8 +69,6 @@ module Posix = {
   [@bs.module "path"] [@bs.scope "posix"]
   external join2: (string, string) => string = "join";
 
-  let (/) = join2;
-
   [@bs.module "path"] [@bs.scope "posix"]
   external normalize: string => string = "normalize";
 
@@ -119,8 +115,6 @@ module Win32 = {
   [@bs.module "path"] [@bs.scope "win32"]
   external join2: (string, string) => string = "join";
 
-  let (/) = join2;
-
   [@bs.module "path"] [@bs.scope "win32"]
   external normalize: string => string = "normalize";
 

diff --git a/tests/PathTest.bs.js b/tests/PathTest.bs.js
diff --git a/tests/PathTest.re b/tests/PathTest.re
@@ -0,0 +1 @@
+Assert.equal(Path.Posix.basename("/tmp/myfile.html"), "myfile.html")