Update echarts-tooltip-carousel.js #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
支持dataset
chengwb53
reviewed
Oct 13, 2021
| @@ -121,12 +121,21 @@ | |||
| let series = chartOption.series; | |||
| let currSeries = series[seriesIndex]; | |||
| if (!series || series.length === 0 || | |||
| !currSeries || !currSeries.type || !currSeries.data || | |||
| !currSeries.data.length) { | |||
chengwb53
reviewed
Oct 13, 2021
| chartType = currSeries.type; // 系列类型 | ||
| dataLen = currSeries.data.length; // 某个系列的数据个数 | ||
|
|
||
| if (currSeries.data) { |
There was a problem hiding this comment.
我看了下dataset相关文档，data存在则会忽略dataset，需要处理下优先级
chengwb53
reviewed
Oct 13, 2021
| } | ||
|
|
||
| if (chartOption.dataset) { | ||
| dataLen = chartOption.dataset.source.length |
There was a problem hiding this comment.
看了下dataset的文档，判断dataLen的准确值比较麻烦，这里只是判断了最简单的，如果能完善下判断就更好了
|
感谢提交PR！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
支持dataset