Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11y pressing esc close the modal #44

Closed
flexbox opened this issue Dec 7, 2018 · 5 comments
Closed

A11y pressing esc close the modal #44

flexbox opened this issue Dec 7, 2018 · 5 comments

Comments

@flexbox
Copy link

flexbox commented Dec 7, 2018

Pressing esc doesn't close the modal.
http://chenjiahan.github.io/rodal/

Tested on Firefox and Google Chrome

@JustOneJance
Copy link

yep, i tested it on Brave and Cromium, add closeOnEsc: true

@JustOneJance
Copy link

I think the library is no longer supported.

var defaultProps = {
    width: 400,
    height: 240,
    measure: 'px',
    visible: false,
    showMask: true,
    showCloseButton: true,
    animation: 'zoom',
    duration: 300,
    className: '',
    customStyles: {},
    customMaskStyles: {}
};

where closeOnEsc in props?

@chenjiahan
Copy link
Owner

@JustOneJance Did you install the latest version?

@JustOneJance
Copy link

sorry my mistake, i understood it when try add new function in your library.

@chenjiahan
Copy link
Owner

👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants