testing

chenos · Feb 5, 2018 · e5046f1 · e5046f1
1 parent 7cf11d1
commit e5046f1
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/src/ModuleLoader.php b/src/ModuleLoader.php
@@ -47,7 +47,7 @@ public function setExtensions(...$extensions)
 
     public function addOverride($name, $override = null)
     {
-        if (func_num_args() == 1 && is_array($name)) {
+        if (is_array($name)) {
             $this->overrides = array_merge($this->overrides, $name);
         } elseif (func_num_args() == 2) {
             $this->overrides[$name] = $override;

diff --git a/tests/ModuleLoaderTest.php b/tests/ModuleLoaderTest.php
@@ -23,6 +23,22 @@ public function setUp()
         $this->v8 = $v8;
     }
 
+    public function testAddOverride1()
+    {
+        $overrides = ['vue' => 'vue/dist/vue.js'];
+        $this->loader->addOverride($overrides);
+        $this->assertAttributeEquals($overrides, 'overrides', $this->loader);
+    }
+
+    public function testAddOverride2()
+    {
+        $overrides = ['vue' => 'vue/dist/vue.js'];
+        foreach ($overrides as $key => $value) {
+            $this->loader->addOverride($key, $value);
+        }
+        $this->assertAttributeEquals($overrides, 'overrides', $this->loader);
+    }
+
     public function testNestRequire()
     {
         $this->assertOutputEquals("require('./fn')();", 'hello1hello2');