更新数据 #502
Open
更新数据 #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd called after handleClose().
…) from non-IO thread, data might be incomplete.
The current impl. has race condition of TcpClient destructs before TcpConnection calling TcpClient::removeConnection(), and TcpClient's loop_ member becomes wild pointer and assertInLoopThread fails because threadId_ is garbage value. Client::onDisconnect() makes the main event loop quits, therefore destructs the TcpClient while TcpConnection connection callback is half-way done in IO thread. The solution is to defer quit of main loop, so TcpClient::removeConnection() finishes first.
这里并没直接用到Singleton，是否可以去掉呢？
Remove unused header EventLoop.cc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.