Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor bugs fixed and code improvement #9

Closed
wants to merge 14 commits into from

Conversation

lamhoangtung
Copy link

@lamhoangtung lamhoangtung commented Aug 5, 2019

Hi. Thanks for you guys for the great works!

Lately I been trying to apply GLNet for real world problem using you guys code and having little bugs here and there. After a month trying to resolve a bunch of them, I finally mange to get GLNet working for my binary segmentation problem.

This PR contain some minor bugs fix and improvement while I working with you guys code.

If this PR don't meet the quality for a merge. It's totally fine but please told me what can I do to complete my contribution to this repo :D

Regards and thanks, Linus ;)

@chenwydj
Copy link
Collaborator

chenwydj commented Aug 5, 2019

This pull request introduces 1 alert when merging 46ebe82 into 867d2a6 - view on LGTM.com

new alerts:

  • 1 for Unused import

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.


Comment posted by LGTM.com

@chenwydj
Copy link
Collaborator

chenwydj commented Aug 5, 2019

This pull request fixes 5 alerts when merging c9d6b4d into 867d2a6 - view on LGTM.com

fixed alerts:

  • 4 for Unused import
  • 1 for NotImplemented is not an Exception

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.


Comment posted by LGTM.com

@chenwydj
Copy link
Collaborator

chenwydj commented Aug 5, 2019

Hi Hoàng Tùng Lâm! Thank you very much for your interest and great effort! I will review your commit and get back to you soon!

@lamhoangtung
Copy link
Author

Thanks @chenwydj ;)

@chenwydj
Copy link
Collaborator

This pull request introduces 1 alert and fixes 5 when merging 0dc47fa into 867d2a6 - view on LGTM.com

new alerts:

  • 1 for Unused import

fixed alerts:

  • 4 for Unused import
  • 1 for NotImplemented is not an Exception

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.


Comment posted by LGTM.com

@lamhoangtung
Copy link
Author

Since everything from training script and pertained model was uploaded by the author. I will close this PR :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants