Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed to record call #207

Closed
crazyuploader opened this issue Dec 27, 2022 · 2 comments · Fixed by #209
Closed

Failed to record call #207

crazyuploader opened this issue Dec 27, 2022 · 2 comments · Fixed by #209
Assignees
@chenxiaolong
Labels
bug Bug in BCR itself

Comments

@crazyuploader
Copy link

Getting an issue where calls are not saved by a particular caller whose name has characters like "$", "¥".

Caller name example: $string¥

Screenshot_20221224-212606_GPay
@chenxiaolong
Copy link
Owner

Interesting. I'm curious where that comes from because BCR does not try to process the caller name in any way. I'll see if I can reproduce the issue with $string¥.

Are you able to receive another call from this caller easily? If so, can you enable debug mode by long pressing the version number and then try the call? BCR will create a log file inside the output directory.

@chenxiaolong chenxiaolong self-assigned this Dec 27, 2022
@chenxiaolong chenxiaolong added the bug Bug in BCR itself label Dec 27, 2022
chenxiaolong added a commit that referenced this issue Dec 27, 2022
@chenxiaolong
FilenameTemplate: Fix potential crash when a variable's value contain…
ad39ee0 
…s \ or $

Matcher.appendReplacement() treats \ and $ specially, so we need to
use Matcher.quoteReplacement() when passing in arbitrary strings.

Fixes: #207

Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
@chenxiaolong chenxiaolong mentioned this issue Dec 27, 2022
Merged
@chenxiaolong
Copy link
Owner

This should be fixed by #209, which will be included in the next version (1.28).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chenxiaolong chenxiaolong

Labels
bug Bug in BCR itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FilenameTemplate: Fix potential crash when a variable's value contains \ or $ chenxiaolong/BCR
2 participants
@chenxiaolong @crazyuploader