Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add contact name to filename #28

Closed
Savaturkey opened this issue May 24, 2022 · 4 comments
Closed

Add contact name to filename #28

Savaturkey opened this issue May 24, 2022 · 4 comments
Assignees
@chenxiaolong
Labels
enhancement New feature or request

Comments

@Savaturkey
Copy link

Savaturkey commented May 24, 2022 •
edited

I may have misunderstood or you may have misunderstood. I want the name of a person in my phonebook to be in the audio recording file. If it's not in my phonebook it already has a phone number. Did you understand me?
Thank you.
@chenxiaolong
Copy link
Owner

Ah, I see. You'd like the filename to contain the name from the contacts.

I'll investigate and see if it's easy to implement. No promises though :)

@chenxiaolong chenxiaolong self-assigned this May 26, 2022
@chenxiaolong chenxiaolong added the enhancement New feature or request label May 26, 2022
@chenxiaolong chenxiaolong changed the title Caller ID Add contact name to filename May 26, 2022
@Savaturkey
Copy link
Author

Ah, I see. You'd like the filename to contain the name from the contacts.

I'll investigate and see if it's easy to implement. No promises though :)

Thank You...

chenxiaolong added a commit that referenced this issue May 28, 2022
@chenxiaolong
Add contact name to output filename
fb226b2 
This is not enabled by default and there's no user interface for
enabling it. The user can only enable the feature by manually going to
the system settings and enabling the Contacts permission for BCR.

Issue: #28
Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
@chenxiaolong chenxiaolong mentioned this issue May 28, 2022
Merged
chenxiaolong added a commit that referenced this issue May 28, 2022
@chenxiaolong
Add contact name to output filename
666ac78 
This is not enabled by default and there's no user interface for
enabling it. The user can only enable the feature by manually going to
the system settings and enabling the Contacts permission for BCR.

Issue: #28
Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
chenxiaolong added a commit that referenced this issue May 28, 2022
@chenxiaolong
Add contact name to output filename
b0dc95e 
This is not enabled by default and there's no user interface for
enabling it. The user can only enable the feature by manually going to
the system settings and enabling the Contacts permission for BCR.

Issue: #28
Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
@chenxiaolong
Copy link
Owner

This has been implemented in #42 and will be included in the next version of BCR (version 1.5).

The feature can be enabled by going into the Android settings and giving BCR the Contacts permission. Also, this feature requires Android 11 or newer. Older versions of Android do not have the necessary API.

@greatcoder88
Copy link

This has been implemented in #42 and will be included in the next version of BCR (version 1.5).

The feature can be enabled by going into the Android settings and giving BCR the Contacts permission. Also, this feature requires Android 11 or newer. Older versions of Android do not have the necessary API.

Thanks for adding the feature to include contact name in file name based on the contacts permission.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chenxiaolong chenxiaolong

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chenxiaolong @greatcoder88 @Savaturkey