Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output Format options cropped on small screens #52

Closed
VarunS2002 opened this issue May 30, 2022 · 2 comments · Fixed by #55
Closed

Output Format options cropped on small screens #52

VarunS2002 opened this issue May 30, 2022 · 2 comments · Fixed by #55
Assignees
@chenxiaolong
Labels
bug Bug in BCR itself

Comments

@VarunS2002
Copy link

On smaller screens it's not possible to select WAV/PCM at all and on larger screens only the text is cut off.
My screen isn't that small either actually: 6.67" 1080x2400 pixels

Screenshot_20220530-151240_BCR.png
@chenxiaolong
Copy link
Owner

Oops! I'll fix that in the next version. I use the smallest screen scaling and font size so I didn't catch that.

@chenxiaolong chenxiaolong self-assigned this May 30, 2022
@chenxiaolong chenxiaolong added the bug Bug in BCR itself label May 30, 2022
@VarunS2002
Copy link
Author

Oh yeah no problem.
Happy to help.

chenxiaolong added a commit that referenced this issue May 30, 2022
@chenxiaolong
Use material3 chips instead of a button group for the output format s…
b1df817 
…elector

The material3 button group cannot handle situations where the buttons
overflow the screen's width. Instead, we'll use a chip group, which is
designed to handle multiline scenarios.

Fixes: #52
Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
@chenxiaolong chenxiaolong mentioned this issue May 30, 2022
Merged
chenxiaolong added a commit that referenced this issue May 30, 2022
@chenxiaolong
Use material3 chips instead of a button group for the output format s…
dcc87ae 
…elector

The material3 button group cannot handle situations where the buttons
overflow the screen's width. Instead, we'll use a chip group, which is
designed to handle multiline scenarios.

Fixes: #52
Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chenxiaolong chenxiaolong

Labels
bug Bug in BCR itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use material3 chips instead of a button group for the output format selector chenxiaolong/BCR
2 participants
@chenxiaolong @VarunS2002