Fix broken share action due to PendingIntent reuse #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intent for the "share" action is not distinguishable across notifications when compared with Intent.filterEquals() because they differ only in intent extras. This would cause the same PendingIntent to be reused for every share action, which would reference an old URI. This commit fixes the issue by setting the ACTION_SEND data to the same value as the EXTRA_STREAM. The intent data is not used for this action, but makes the intent sufficiently unique that a PendingIntent won't be reused. Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
chenxiaolong
force-pushed
the
notification-confusion
branch
from
560c148
to
93fda87
Compare
chenxiaolong
added a commit
that referenced
this pull request
Nov 28, 2022
Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent for the "share" action is not distinguishable across notifications when compared with Intent.filterEquals() because they differ only in intent extras. This would cause the same PendingIntent to be reused for every share action, which would reference an old URI.
This commit fixes the issue by setting the ACTION_SEND data to the same value as the EXTRA_STREAM. The intent data is not used for this action, but makes the intent sufficiently unique that a PendingIntent won't be reused.