Add new option for starting the recording in the paused state #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new "initially paused" option to BCR's UI. If it's disabled, then BCR works as it always has: calls are recorded as soon as they enter the connected state. If the option is enabled, then the recording starts in the paused state. The user can choose to resume via BCR's persistent notification. If the recording is never resumed, then the empty output file is deleted and no success notification will be shown. This new option is disabled by default. Issue: #198 Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
chenxiaolong
force-pushed
the
initially_paused
branch
from
b5b92d9
to
da82c37
Compare
chenxiaolong
added a commit
that referenced
this pull request
Dec 28, 2022
Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new "initially paused" option to BCR's UI. If it's disabled, then BCR works as it always has: calls are recorded as soon as they enter the connected state. If the option is enabled, then the recording starts in the paused state. The user can choose to resume via BCR's persistent notification. If the recording is never resumed, then the empty output file is deleted and no success notification will be shown.
This new option is disabled by default.
Issue: #198