Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app/proguard-rules.pro: Keep TreeDocumentFile constructor #261

Merged
merged 2 commits into from
Mar 1, 2023

Conversation

chenxiaolong
Copy link
Owner

We call it via reflection in our faster DocumentFile extensions and the first parameter was being optimized out in release builds because it is always null in the usages that R8 is able to analyze.

Related-to: #257
Fixes: #260

We call it via reflection in our faster DocumentFile extensions and the
first parameter was being optimized out in release builds because it is
always null in the usages that R8 is able to analyze.

Related-to: #257
Fixes: #260

Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
@chenxiaolong chenxiaolong self-assigned this Mar 1, 2023
It basically serves as a debug-signed release build.

Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
@chenxiaolong chenxiaolong merged commit c955f6c into master Mar 1, 2023
@chenxiaolong chenxiaolong deleted the debug branch March 1, 2023 22:03
chenxiaolong added a commit that referenced this pull request Mar 1, 2023
Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom name template is failing to load
1 participant