Add support for WAV/PCM output #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Format" is used to reference a specific file format (container + encoded audio stream). "Codec" will be used to reference an encoder or decoder. The naming in the code now matches the user-facing strings. Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
It doesn't matter if the resulting string is a valid URI. The redaction is for log messages only. Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
This is primarily for troubleshooting. With this output format, the entire MediaCodec/MediaMuxer pipeline is bypassed and the raw PCM samples are directly written to the output file. Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
chenxiaolong
force-pushed
the
wave-output2
branch
from
00277fd
to
e92637a
Compare
chenxiaolong
added a commit
that referenced
this pull request
May 29, 2022
Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is primarily for troubleshooting. With this output format, the entire
MediaCodec/MediaMuxerpipeline is bypassed and the raw PCM samples are directly written to the output file.