RecorderThread: Make AudioRecord internal buffer less excessively large #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the call ends, everything still remaining in AudioRecord's internal buffer is lost because there's no way to read the remaining bytes after recording is stopped. With 20x the buffer size on eg. a device with a 1920 byte minimum buffer size and a sample rate of 8000 Hz, this may cause 2.4 seconds of audio at the end of the call to be lost. This commit should not have a negative effect since the large buffer size was meant to address buffer overruns and the root cause of that problem was fixed in #72. Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
chenxiaolong
added a commit
that referenced
this pull request
Jun 7, 2022
Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the call ends, everything still remaining in AudioRecord's internal
buffer is lost because there's no way to read the remaining bytes after
recording is stopped. With 20x the buffer size on eg. a device with a
1920 byte minimum buffer size and a sample rate of 8000 Hz, this may
cause 2.4 seconds of audio at the end of the call to be lost.
This commit should not have a negative effect since the large buffer
size was meant to address buffer overruns and the root cause of that
problem was fixed in #72.