Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue10, add design doc for session expiration handling #11

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

brucewu-fly
Copy link
Collaborator

new file:   doc/SESSION_EXPIRATION.md
Required for all non-trivial PRs
  • Rebased/mergable
  • Tests pass
  • CHANGELOG.md updated
  • Sign CLA (if not already signed)
Required only if applicable

You can erase any checkboxes below this note if they are not applicable to your Pull Request.

  • InfluxQL Spec updated
  • Provide example syntax
  • Update man page when modifying a command
  • Config changes: update sample config (etc/config.sample.toml), server NewDemoConfig method, and Diagnostics methods reporting config settings, if necessary
  • InfluxData Documentation: issue filed or pull request submitted <link to issue or pull request>

@brucewu-fly brucewu-fly changed the title feature/issue10, add design doc for session expiration handling Feature/issue10, add design doc for session expiration handling Jul 10, 2017
@chenziliang
Copy link
Owner

chenziliang commented Jul 11, 2017

  1. Could you please rename SESSION_EXPIRATION.md to MASTER_SESSION_EXPIRATION.md since only the master handles the connection to etcd in phase 1 ?
  2. Session expiration and auto connect is a builtin feature in etcd ? So please help investigate. what we will need do is just subscribe the session expiration event and reject all coming requests ?

@chenziliang
Copy link
Owner

@brucewu-fly How do we know the session has expired and then reconnected from the code ? How to handle this session time out by using a callback or subscribe a timeout message ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants