Add a workflow to lint semantic prs #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankurdotb
previously approved these changes
May 18, 2022
|
@askolesov I switched to a different one for greater control on PR titles, e.g., pre-built rules for Sentence case vs having to build it all myself. As a consequence, I also switched the upstream action to one from Conde Nast. Have a look and let me know what you think? |
ankurdotb
approved these changes
May 18, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why a separate workflow? Because of the different trigger -
pull_request_target. This people who contribute not to wait for our approval to run this check.P.S. This check will appear in ongoing PRs because of
targetcontext. We can't see it in this PR and it's OK.