Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Base validation fetchStatusList2021 #299

Merged
merged 2 commits into from
Jul 4, 2023
Merged

fix: Base validation fetchStatusList2021 #299

merged 2 commits into from
Jul 4, 2023

Conversation

DaevMithran
Copy link
Contributor

@DaevMithran DaevMithran commented Jul 4, 2023 •
edited

  • fetchStatusList2021 now does a basic validation resource content
  • minor bug fix in returning error in catch block, the error should be a template literal instead of assigning it directly

@ankurdotb
Copy link
Contributor

Task linked: DEV-2906 Validate resource data in fetchStatusList2021

@Eengineer1
Copy link
Contributor

No, error of type unknown shouldn't be type casted to string, especially throwable interfaces with trivial interpolation behaviour.
Instead, cast it in your top-level application logic, if that's what you need.

Plus, what's the reasoning behind "should"?

I see value in fetch validation, so approved.

Eengineer1
Eengineer1 approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@Eengineer1 Eengineer1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DaevMithran Left feedback on your suggestions.

Fetch base validation is approved.

Thanks.

@Eengineer1 Eengineer1 changed the title fix: Error handling fetchStatusList2021 fix: Base validation fetchStatusList2021 Jul 4, 2023
@Eengineer1 Eengineer1 merged commit 208dde3 into develop Jul 4, 2023
12 checks passed
@Eengineer1 Eengineer1 deleted the DEV-2906 branch July 4, 2023 16:30
@DaevMithran
Copy link
Contributor Author

No, error of type unknown shouldn't be type casted to string, especially throwable interfaces with trivial interpolation behaviour.
Instead, cast it in your top-level application logic, if that's what you need.

Plus, what's the reasoning behind "should"?

I see value in fetch validation, so approved.

@Eengineer1 without typecasting to a string the error is not returned at all. I'm just getting error as an empty object

cheqd-bot bot pushed a commit that referenced this pull request Jul 4, 2023
@semantic-release-bot
chore(release): 3.4.2-develop.1 [skip ci]
d653ac3 
## [3.4.2-develop.1](3.4.1...3.4.2-develop.1) (2023-07-04)

### Bug Fixes

* Base validation fetchStatusList2021 ([#299](#299)) ([208dde3](208dde3))
@cheqd-bot
Copy link

cheqd-bot bot commented Jul 4, 2023

🎉 This PR is included in version 3.4.2-develop.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

cheqd-bot bot pushed a commit that referenced this pull request Jul 10, 2023
@semantic-release-bot
chore(release): 3.5.0 [skip ci]
a58b23b 
## [3.5.0](3.4.1...3.5.0) (2023-07-10)

### Features

* Include fetchRemoteContexts in verify apis ([#305](#305)) ([ae6632f](ae6632f))
* Merge Down ([#304](#304)) ([3037687](3037687))
* Support custom verification policies && domain ([#287](#287)) ([403ec16](403ec16))
* Support statusOptions in cheqdCheckCredentialStatus ([#303](#303)) ([14c4f8c](14c4f8c))

### Bug Fixes

* Base validation fetchStatusList2021 ([#299](#299)) ([208dde3](208dde3))
* Make verification result aligned with upstream [DEV-2827] ([#302](#302)) ([eddd11f](eddd11f))
@cheqd-bot
Copy link

cheqd-bot bot commented Jul 10, 2023

🎉 This PR is included in version 3.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@cheqd-bot cheqd-bot bot added the released label Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eengineer1 Eengineer1 Eengineer1 approved these changes

Assignees
No one assigned
Labels
released on @beta released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DaevMithran @ankurdotb @Eengineer1