Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make verification result aligned with upstream [DEV-2827] #302

Merged
merged 4 commits into from
Jul 7, 2023

Conversation

DaevMithran
Copy link
Contributor

@DaevMithran DaevMithran commented Jul 5, 2023

This PR appends the verification result returned in upstream in the response for verifyCredential and verifyPresentation to make it more consistent. Overiding credential status results.

The verification result contains the below fields

  • verified
  • issuer
  • signer
  • verifiableCredential / verifiablePresentatoin
  • policies
  • jwt

@ankurdotb
Copy link
Contributor

@ankurdotb ankurdotb changed the title feat: Make verification result aligned with upstream fix: Make verification result aligned with upstream [DEV-2827] Jul 7, 2023
@ankurdotb ankurdotb merged commit eddd11f into develop Jul 7, 2023
6 checks passed
@ankurdotb ankurdotb deleted the DEV-2927 branch July 7, 2023 12:44
cheqd-bot bot pushed a commit that referenced this pull request Jul 7, 2023
## [3.5.0-develop.3](3.5.0-develop.2...3.5.0-develop.3) (2023-07-07)

### Bug Fixes

* Make verification result aligned with upstream [DEV-2827] ([#302](#302)) ([eddd11f](eddd11f))
@cheqd-bot
Copy link

cheqd-bot bot commented Jul 7, 2023

🎉 This PR is included in version 3.5.0-develop.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

cheqd-bot bot pushed a commit that referenced this pull request Jul 10, 2023
## [3.5.0](3.4.1...3.5.0) (2023-07-10)

### Features

* Include fetchRemoteContexts in verify apis ([#305](#305)) ([ae6632f](ae6632f))
* Merge Down ([#304](#304)) ([3037687](3037687))
* Support custom verification policies && domain ([#287](#287)) ([403ec16](403ec16))
* Support statusOptions in cheqdCheckCredentialStatus ([#303](#303)) ([14c4f8c](14c4f8c))

### Bug Fixes

* Base validation fetchStatusList2021 ([#299](#299)) ([208dde3](208dde3))
* Make verification result aligned with upstream [DEV-2827] ([#302](#302)) ([eddd11f](eddd11f))
@cheqd-bot
Copy link

cheqd-bot bot commented Jul 10, 2023

🎉 This PR is included in version 3.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@cheqd-bot cheqd-bot bot added the released label Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants