Skip to content

Commit

Permalink
"Possible memory leak. Dynamic memory stored in 'n' allocated through
Browse files Browse the repository at this point in the history
function 'malloc' at line 868 can be lost at line 891" (Klocwork.com
Issue #43)

git-svn-id: svn://cherokee-project.com/cherokee/trunk@6680 5dc97367-97f1-0310-9951-d761b3857238
  • Loading branch information
alobbs committed May 22, 2011
1 parent 1418874 commit cd3d922
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions cherokee/handler_server_info.c
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -884,21 +884,25 @@ cherokee_handler_server_info_new (cherokee_handler_t **hdl,
*/ */
ret = cherokee_buffer_init (&n->buffer); ret = cherokee_buffer_init (&n->buffer);
if (unlikely(ret != ret_ok)) if (unlikely(ret != ret_ok))
return ret; goto error;


ret = cherokee_buffer_ensure_size (&n->buffer, 4*1024); ret = cherokee_buffer_ensure_size (&n->buffer, 4*1024);
if (unlikely(ret != ret_ok)) if (unlikely(ret != ret_ok))
return ret; goto error;


ret = cherokee_dwriter_init (&n->writer, &CONN_THREAD(cnt)->tmp_buf1); ret = cherokee_dwriter_init (&n->writer, &CONN_THREAD(cnt)->tmp_buf1);
if (unlikely(ret != ret_ok)) if (unlikely(ret != ret_ok))
return ret; goto error;


n->writer.pretty = true; n->writer.pretty = true;
cherokee_dwriter_set_buffer (&n->writer, &n->buffer); cherokee_dwriter_set_buffer (&n->writer, &n->buffer);


*hdl = HANDLER(n); *hdl = HANDLER(n);
return ret_ok; return ret_ok;

error:
cherokee_handler_free (HANDLER(n));
return ret_error;
} }




Expand Down

0 comments on commit cd3d922

Please sign in to comment.