Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v6.5.0 release failed #112

Closed
1 of 3 tasks
webknjaz opened this issue Sep 2, 2018 · 5 comments
Closed
1 of 3 tasks

v6.5.0 release failed #112

webknjaz opened this issue Sep 2, 2018 · 5 comments
Assignees
Labels
bug Something is broken help wanted Somebody help us, please! regression Something that worked earlier got broken in new release

Comments

@webknjaz
Copy link
Member

webknjaz commented Sep 2, 2018

It looks like doctests are failing under macOS

I'm submitting a ...

  • bug report
  • feature request
  • question about the decisions made in the repository

Describe the bug. What is the current behavior?

What is the motivation / use case for changing the behavior?
Fix release process

To Reproduce

https://travis-ci.org/cherrypy/cheroot/builds/422117270

Expected behavior

Release published on PyPI

Details

Environment

  • Cheroot version: 6.5.0
  • CherryPy version: NA
  • Python version: 3.6/3.7
  • OS: macOS @ Travis CI
  • Browser: N/A

Additional context

@webknjaz webknjaz added bug Something is broken regression Something that worked earlier got broken in new release help wanted Somebody help us, please! labels Sep 2, 2018
@jaraco
Copy link
Member

jaraco commented Sep 2, 2018

I just ran the tests on my mac at 9f77c31, and they passed.

@jaraco
Copy link
Member

jaraco commented Sep 2, 2018

The issue for at least one of the failed builds is pytest-dev/pytest#3888, which explains why the tests didn't fail on my machine, which picked up a later version of pytest (3.7.4).

That issue was addressed in jaraco/skeleton@5633116de3, so I'll merge in that change and other ones, which should address the issue and maybe others.

@jaraco
Copy link
Member

jaraco commented Sep 2, 2018

In 85c6dfa, I've merged the skeleton, which should fix the test failures. I've run out of time to work on it, though, so I'm going to have to leave it and hope for the best.

@jaraco jaraco closed this as completed Sep 2, 2018
@webknjaz
Copy link
Member Author

webknjaz commented Sep 2, 2018

Thanks, I'll restart that canceled job in this build to make it publish dists: https://travis-ci.org/cherrypy/cheroot/jobs/422117286

@webknjaz
Copy link
Member Author

webknjaz commented Sep 2, 2018

@jaraco I'll revert a few changes from that merge, which break things (Python 3.7 job, markdown rendering)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken help wanted Somebody help us, please! regression Something that worked earlier got broken in new release
Projects
None yet
Development

No branches or pull requests

2 participants