[do not merge] Exp on pr277 and exercise the CI #287
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y#263. The previous behaviour was that when we exceed our threshold of permitted keep-alive connections, we would evict the least recently used connection by forcibly shutting down the socket. This would cause problems with clients which wouldn't be expecting socket errors. Now, if we have a connection that we would usually keep-alive, but we have already reached our limit of allowed keep-alive connections, then we close the connection gracefully by sending a "Connection: Close" header for HTTP/1.1 or omitting the "Connection" header for HTTP/1.0. This has the downside of having cheroot holding on to connections which are less recently used, rather than the most recent ones - but it does ensure that we make the decision about whether to keep or drop a connection at the time we are writing the headers, which allows the client to have a better expectation about the state of the socket once the response has been read. However, we still forcibly close sockets for idle keep-alive connections once the server timeout has been exceeded.
…tions." This reverts commit 0bb15fc.
morucci
force-pushed
the
exp-pr277
branch
3 times, most recently
from
9c3654a
to
d54ccce
Compare
morucci
force-pushed
the
exp-pr277
branch
2 times, most recently
from
dbbee24
to
7029460
Compare
morucci
force-pushed
the
exp-pr277
branch
2 times, most recently
from
e8698b5
to
1f71924
Compare
13 tasks
|
I've merged #277 with a few hacks in tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experiment for pr277
This change is