Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use current_thread() in order to remove DeprecationWarning #370

Merged
merged 4 commits into from May 18, 2021

Conversation

soham4abc
Copy link
Contributor

@soham4abc soham4abc commented May 17, 2021

❓ What kind of change does this PR introduce?

  • 🐞 bug fix
  • 🐣 feature
  • πŸ“‹ docs update
  • πŸ“‹ tests/coverage improvement
  • πŸ“‹ refactoring
  • πŸ’₯ other

πŸ“‹ What is the related issue number (starting with #)

#369

πŸ“‹ Checklist:

  • I think the code is well written
  • I wrote good commit messages
  • I have squashed related commits together after the changes have been approved
  • Unit tests for the changes exist
  • Integration tests for the changes exist (if applicable)
  • I used the same coding conventions as the rest of the project
  • The new code doesn't generate linter offenses
  • Documentation reflects the changes
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences

This change is Reviewable

@webknjaz webknjaz changed the title Used current_thread() in order to remove DeprecationWarning Use current_thread() in order to remove DeprecationWarning May 18, 2021
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this, to make the patch acceptable, it should be cleaned up first, though.

Please, don't include unrelated setup of your IDE in this PR. And also, exclude all of the formatting changes β€” the PR title says that a method invocation is changed so it should do exactly that.

@soham4abc soham4abc requested a review from webknjaz May 18, 2021 06:46
@soham4abc
Copy link
Contributor Author

soham4abc commented May 18, 2021

I have done the requested changes. Please do look into it and thanks for reviewing and guiding me to this codebase.

Thanks for looking into this, to make the patch acceptable, it should be cleaned up first, though.

Please, don't include unrelated setup of your IDE in this PR. And also, exclude all of the formatting changes β€” the PR title says that a method invocation is changed so it should do exactly that.

Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants