Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use modern thread name attribute API instead of the deprecated methods #371

Merged
merged 11 commits into from Jun 7, 2021
Merged

Use modern thread name attribute API instead of the deprecated methods #371

merged 11 commits into from Jun 7, 2021

Conversation

soham4abc
Copy link
Contributor

@soham4abc soham4abc commented May 20, 2021 •
edited by webknjaz

❓ What kind of change does this PR introduce?

  • 🐞 bug fix
  • 🐣 feature
  • 📋 docs update
  • 📋 tests/coverage improvement
  • 📋 refactoring
  • 💥 other

📋 What is the related issue number (starting with #)

Resolves #369

📋 Checklist:

  • I think the code is well written
  • I wrote good commit messages
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences

This change is Reviewable

@soham4abc
Copy link
Contributor Author

my bad

@soham4abc soham4abc closed this May 20, 2021
@webknjaz
Copy link
Member

Do you want to try again? The diff looks fine

@webknjaz webknjaz added the bug Something is broken label May 20, 2021
@soham4abc
Copy link
Contributor Author

Do you want to try again? The diff looks fine

The builds failed miserably. If you want I can re issue the PR.

@webknjaz webknjaz reopened this May 20, 2021
@soham4abc
Copy link
Contributor Author

looks good?

@soham4abc
Copy link
Contributor Author

Mail says PR run failed

@webknjaz
Copy link
Member

The docs jobs failures are unrelated and the test matrix didn't get fully executed — maybe GHA was having some internal platform issues. FWIW I restarted the test jobs to see how it goes.

@webknjaz webknjaz changed the title using get_name() and set_name() in order to fix DeprecationWarning Use modern thread name attribute access/modification API instead of the deprecated methods Jun 7, 2021
@webknjaz webknjaz changed the title Use modern thread name attribute access/modification API instead of the deprecated methods Use modern thread name attribute API instead of the deprecated methods Jun 7, 2021
@webknjaz webknjaz merged commit 7af66b0 into cherrypy:master Jun 7, 2021
@bnavigator bnavigator mentioned this pull request Jan 22, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz webknjaz left review comments

Assignees
No one assigned
Labels
bug Something is broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DeprecationWarning: currentThread() is deprecated, use current_thread() instead
2 participants
@soham4abc @webknjaz