Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types for _compat.py #491

Merged
merged 1 commit into from
Feb 10, 2022
Merged

Add types for _compat.py #491

merged 1 commit into from
Feb 10, 2022

Conversation

kasium
Copy link
Contributor

@kasium kasium commented Feb 10, 2022

Add pyi files for cheroot._compat

❓ What kind of change does this PR introduce?

  • 🐞 bug fix
  • 🐣 feature
  • πŸ“‹ docs update
  • πŸ“‹ tests/coverage improvement
  • πŸ“‹ refactoring
  • πŸ’₯ other

πŸ“‹ What is the related issue number (starting with #)

Part of #384

❓ What is the current behavior? (You can also link to an open issue here)

cheroot._compat is not typed

❓ What is the new behavior (if this is a feature change)?

cheroot._compat is typed

πŸ“‹ Contribution checklist:

(If you're a first-timer, check out
this guide on making great pull requests)

  • I wrote descriptive pull request text above
  • I think the code is well written
  • I wrote good commit messages
  • I have squashed related commits together after
    the changes have been approved
  • Unit tests for the changes exist
  • Integration tests for the changes exist (if applicable)
  • I used the same coding conventions as the rest of the project
  • The new code doesn't generate linter offenses
  • Documentation reflects the changes
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences

This change is Reviewable

@kasium kasium mentioned this pull request Feb 10, 2022
3 tasks
@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

Merging #491 (eeea95f) into master (22eda80) will decrease coverage by 0.31%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #491      +/-   ##
==========================================
- Coverage   80.56%   80.24%   -0.32%     
==========================================
  Files          28       28              
  Lines        4409     4409              
==========================================
- Hits         3552     3538      -14     
- Misses        857      871      +14     

@kasium
Copy link
Contributor Author

kasium commented Feb 10, 2022

@webknjaz can you please have a look? I guess the CI is a little bit flaky

@webknjaz
Copy link
Member

xmlrpc.client.ProtocolError: <ProtocolError for pypi.python.org/pypi: 503 Service Unavailable>

This seems to be related to PyPI disabling XML-RPC.

@webknjaz webknjaz merged commit 81f9c68 into cherrypy:master Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants