Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set worker thread names as str #503

Merged
merged 1 commit into from
Oct 2, 2022
Merged

Conversation

jarus
Copy link
Contributor

@jarus jarus commented Apr 22, 2022

❓ What kind of change does this PR introduce?

  • 🐞 bug fix
  • 🐣 feature
  • πŸ“‹ docs update
  • πŸ“‹ tests/coverage improvement
  • πŸ“‹ refactoring
  • πŸ’₯ other

πŸ“‹ What is the related issue number (starting with #)

None

❓ What is the current behavior? (You can also link to an open issue here)
Since the refactoring 7af66b0 the Cheroot worker threads are named like "('CP Server Thread-9',)".

❓ What is the new behavior (if this is a feature change)?
The worker threads are again correctly named "CP Server Thread-$i".

πŸ“‹ Other information:
A leftover comma transformed the string to a tuple.

πŸ“‹ Contribution checklist:

(If you're a first-timer, check out
this guide on making great pull requests)

  • I wrote descriptive pull request text above
  • I think the code is well written
  • I wrote good commit messages
  • I have squashed related commits together after
    the changes have been approved
  • Unit tests for the changes exist
  • Integration tests for the changes exist (if applicable)
  • I used the same coding conventions as the rest of the project
  • The new code doesn't generate linter offenses
  • Documentation reflects the changes
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences

This change is Reviewable

Since the refactoring 7af66b0 the Cheroot worker threads are
named like "('CP Server Thread-9',)". A leftover comma transformed
the string to a tuple.
@the-allanc
Copy link
Contributor

Any chance we can get this merged in?

@webknjaz
Copy link
Member

webknjaz commented Oct 1, 2022

Any chance we can get this merged in?

Sorry, I haven't been really watching FOSS those days but I'll merge this soon.

@webknjaz webknjaz merged commit a41a557 into cherrypy:main Oct 2, 2022
@webknjaz
Copy link
Member

webknjaz commented Oct 2, 2022

@jarus @pR0Ps thanks both of you for preparing the patches!

@webknjaz webknjaz changed the title Set worker thread names as str Set worker thread names as str Oct 2, 2022
@webknjaz webknjaz added the bug Something is broken label Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants