Don't use SO_REUSEADDR on Windows #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows the SO_REUSEADDR sockopt has different semantics, so we don't want to enable it there. See https://msdn.microsoft.com/en-us/library/ms740621(v=vs.85).aspx Fixes cherrypy/cherrypy#1088 Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>
webknjaz
reviewed
Oct 16, 2017
Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>
Codecov Report
@@ Coverage Diff @@
## master #53 +/- ##
==========================================
- Coverage 58.98% 58.87% -0.11%
==========================================
Files 18 18
Lines 3279 3280 +1
==========================================
- Hits 1934 1931 -3
- Misses 1345 1349 +4 |
|
Do you want me to add the msdn link as well? And should I squash the two commits? |
|
Yeah, it would be nice to have that link and maybe some test. Don't squash commits. |
|
Not sure what kind of test you were thinking? Try to bind an instance, and checking if the sockopt is set would work I guess, but it doesn't feel like that would be a very useful test, hm. |
Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>
|
Well, I'll accept this PR without additional test for now. Just wanted to hear your suggestions. |
webknjaz
approved these changes
Oct 17, 2017
|
@kyrias thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix(?)
#)cherrypy/cherrypy#1088
To bind using SO_REUSEADDR on all platforms
To not bind using SO_REUSEADDR on Windows.
https://msdn.microsoft.com/en-us/library/ms740621(v=vs.85).aspx