Fix check for windows OS in cheroot.server #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check was inverted in: commit 31806a8 Author: Sviatoslav Sydorenko <wk@sydorenko.org.ua> Date: Sun Apr 8 20:44:16 2018 +0200 Optimize check for windows OS in cheroot.server
|
@jwegger thanks for pointing that out! Will merge and release bugfix as soon as CIs compete. |
|
Awesome, thanks! |
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
==========================================
- Coverage 65.99% 65.52% -0.48%
==========================================
Files 17 17
Lines 2941 2941
==========================================
- Hits 1941 1927 -14
- Misses 1000 1014 +14 |
|
It's weird: AppVeyor CI didn't get triggered |
|
Triggered the webhook manually: https://ci.appveyor.com/project/CherryPy/cheroot/build/323 |
webknjaz
added
bug
|
Bugfix release v6.2.1 is on its way to PYPI: https://travis-ci.org/cherrypy/cheroot/builds/364627019 (ETA: 30 min) |
|
You're welcome, thanks for the quick release! Verfified that v6.2.1 fixes the issues I had. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check was inverted in:
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the related issue number (starting with
#)No issue filed
What is the current behavior? (You can also link to an open issue here)
CherryPy tests and servers started failing on v6.2.0 with 'address already in use'
when restarted. Bisected the issue and found the fairly obvious error in 31806a8
What is the new behavior (if this is a feature change)?
Fixes bug