New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check for windows OS in cheroot.server #83

Merged
merged 1 commit into from Apr 10, 2018

Conversation

Projects
None yet
2 participants
@jwegger

jwegger commented Apr 10, 2018

Check was inverted in:

commit 31806a8d138586f888c6085511e66513767bca69
Author: Sviatoslav Sydorenko <xx@xxxxxxxxx.xxx.xx>
Date:   Sun Apr 8 20:44:16 2018 +0200

    Optimize check for windows OS in cheroot.server
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug fix

  • What is the related issue number (starting with #)
    No issue filed

  • What is the current behavior? (You can also link to an open issue here)
    CherryPy tests and servers started failing on v6.2.0 with 'address already in use'
    when restarted. Bisected the issue and found the fairly obvious error in 31806a8

  • What is the new behavior (if this is a feature change)?
    Fixes bug

Jan Wegger
Fix check for windows OS in cheroot.server
Check was inverted in:

commit 31806a8
Author: Sviatoslav Sydorenko <wk@sydorenko.org.ua>
Date:   Sun Apr 8 20:44:16 2018 +0200

    Optimize check for windows OS in cheroot.server
@webknjaz

This comment has been minimized.

Member

webknjaz commented Apr 10, 2018

@jwegger thanks for pointing that out! Will merge and release bugfix as soon as CIs compete.

@jwegger

This comment has been minimized.

jwegger commented Apr 10, 2018

Awesome, thanks!

@codecov

This comment has been minimized.

codecov bot commented Apr 10, 2018

Codecov Report

Merging #83 into master will decrease coverage by 0.47%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
- Coverage   65.99%   65.52%   -0.48%     
==========================================
  Files          17       17              
  Lines        2941     2941              
==========================================
- Hits         1941     1927      -14     
- Misses       1000     1014      +14
@webknjaz

This comment has been minimized.

Member

webknjaz commented Apr 10, 2018

It's weird: AppVeyor CI didn't get triggered

@webknjaz

This comment has been minimized.

Member

webknjaz commented Apr 10, 2018

@webknjaz webknjaz merged commit 82797b2 into cherrypy:master Apr 10, 2018

8 checks passed

WIP ready for review
Details
ci/circleci: linux-build Your tests passed on CircleCI!
Details
ci/circleci: macos-build Your tests passed on CircleCI!
Details
codeclimate All good!
Details
codecov/patch 100% of diff hit (target 65.99%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
lgtm analysis: Python No alert changes
Details
@webknjaz

This comment has been minimized.

Member

webknjaz commented Apr 10, 2018

Bugfix release v6.2.1 is on its way to PYPI: https://travis-ci.org/cherrypy/cheroot/builds/364627019 (ETA: 30 min)
Thank you again!

@jwegger

This comment has been minimized.

jwegger commented Apr 10, 2018

You're welcome, thanks for the quick release! Verfified that v6.2.1 fixes the issues I had.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment