Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CPWSGIServer.version contains CherryPy version + Cheroot version #1568

Closed
wants to merge 1 commit into from
Closed

CPWSGIServer.version contains CherryPy version + Cheroot version #1568

wants to merge 1 commit into from

Conversation

mar10
Copy link
Contributor

@mar10 mar10 commented Feb 26, 2017

@mar10
Copy link
Contributor Author

mar10 commented Feb 26, 2017

This is a proposal related to cherrypy/cheroot#12
As explained there, i currently have problems to get the tests running, and also could need a hint were would be a good place to add a test for this change.

@mar10 mar10 mentioned this pull request Mar 11, 2017
Merged
webknjaz
webknjaz reviewed Mar 11, 2017
View reviewed changes
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please increase min version of cheroot in setup.py to v5.2.1?

@mar10
Copy link
Contributor Author

mar10 commented Mar 11, 2017

Ok. I also created an issue for this, that I will reference: #1579 .
Btw.: do you think that bumping the patch number should generally be part of PR's?
PR authors won't know in advance if it get's accepted, in which order and on which target release it may land.

@mar10
Copy link
Contributor Author

mar10 commented Mar 11, 2017

ok, sorry, forget my 'btw'... I misunderstood

@mar10
Copy link
Contributor Author

mar10 commented Mar 11, 2017

I based this PR on the master branch. Let's close this mess and proceed with #1580 instead.
Sorry for the confusion.

@mar10 mar10 closed this Mar 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz webknjaz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mar10 @webknjaz