Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace links to cherrypy.org with cherrypy.dev #1928

Merged
merged 2 commits into from Sep 7, 2021

Conversation

mbm-c
Copy link
Contributor

@mbm-c mbm-c commented Sep 1, 2021

What kind of change does this PR introduce?

  • bug fix
  • feature
  • docs update
  • tests/coverage improvement
  • refactoring
  • other

What is the related issue number (starting with #)

What is the current behavior? (You can also link to an open issue here)
Reame document was having broken links to https://cherrypy.org/, which is not accessible anymore

What is the new behavior (if this is a feature change)?
Links have been changed to use https://cherrypy.readthedocs.io/ as the endpoint

Other information:

Checklist:

  • I think the code is well written
  • I wrote good commit messages
  • I have squashed related commits together after the changes have been approved
  • Unit tests for the changes exist
  • Integration tests for the changes exist (if applicable)
  • I used the same coding conventions as the rest of the project
  • The new code doesn't generate linter offenses
  • Documentation reflects the changes
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences

@abhishekmadhu
Copy link

We need this.

Today if you go to this site (https://www.cherrypy.org) then you will be greeted by some blog which is really shocking to some degree.

@mbm-c mbm-c changed the title Fix broken links to cherrypy.org Remove broken links to cherrypy.org Sep 7, 2021
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
@webknjaz webknjaz changed the title Remove broken links to cherrypy.org Replace links to cherrypy.org with cherrypy.dev Sep 7, 2021
@webknjaz
Copy link
Member

webknjaz commented Sep 7, 2021

Thanks all!

@webknjaz webknjaz merged commit a7983fe into cherrypy:main Sep 7, 2021
@webknjaz
Copy link
Member

webknjaz commented Sep 7, 2021

FTR cherrypy.org should be replaced with cherrypy.dev everywhere, this PR doesn't address all the places: https://github.com/search?q=org%3Acherrypy+cherrypy.org&type=code.

@mbm-c
Copy link
Contributor Author

mbm-c commented Sep 8, 2021

FTR cherrypy.org should be replaced with cherrypy.dev everywhere, this PR doesn't address all the places: https://github.com/search?q=org%3Acherrypy+cherrypy.org&type=code.

would be happy to create a new pr for fixing all the references.

@webknjaz
Copy link
Member

webknjaz commented Sep 8, 2021

Feel free to proceed. In this repo and others under the org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants